Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make stop() accept an expression. Fixes #1457 #1577

Merged
merged 3 commits into from
Oct 23, 2020
Merged

Conversation

davidkpiano
Copy link
Member

This PR allows expressions to be used in the stop() action creator:

actions: stop(context => context.someActor)

This should be the way to stop spawned and invoked actors (as well as activities in v4, which are going away in v5 in favor of invoked actors).

@changeset-bot
Copy link

changeset-bot bot commented Oct 21, 2020

🦋 Changeset detected

Latest commit: 83d8ffb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
xstate Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

packages/core/test/interpreter.test.ts Outdated Show resolved Hide resolved
Co-authored-by: Mateusz Burzyński <mateuszburzynski@gmail.com>
@davidkpiano davidkpiano merged commit af1f52d into master Oct 23, 2020
@davidkpiano davidkpiano deleted the davidkpiano/1457-2 branch October 23, 2020 16:55
@github-actions github-actions bot mentioned this pull request Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants