Ensure children are removed when stopped. Fixes #1457 #1559
Conversation
|
| expect(service.children.get('machineChild')).toBeUndefined(); | ||
| expect(service.children.get('promiseChild')).toBeUndefined(); | ||
| expect(service.children.get('observableChild')).toBeUndefined(); | ||
| done(); |
There was a problem hiding this comment.
I'm not sure if this really should be allowed. It's basically bypassing the machinery of state machine, allowing for arbitrary, imperative, manipulation of its internal state. This also doesn't quite deliver proper cleanup:
typeof service.state.context.machineRef === 'object'
typeof service.state.context.promiseRef === 'object'
typeof service.state.context. observableRef === 'object'This is the common case - spawned actors are usually assigned to the context. Clearing context values would definitely be too magical (and not trivial - with the current APIs it would require a full crawl of the current context).
|
Will rework this to use the |
Depends on #795