Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vue machine component #874

Closed

Conversation

AleksejDix
Copy link
Contributor

@AleksejDix AleksejDix commented Dec 13, 2019

Add Vue Components which can be used without Composition API by using the
Renderless component pattern
https://vuejs.org/v2/guide/components-slots.html#Scoped-Slots

Can be merged after:
#864

Help wanted to implement types with Vue.

@changeset-bot
Copy link

changeset-bot bot commented Dec 13, 2019

💥 No Changeset

Latest commit: 6bfa001

Merging this PR will not cause any packages to be released. If these changes should not cause updates to packages in this repo, this is fine 🙂

If these changes should be published to npm, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 13, 2019

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6bfa001:

Sandbox Source
cocky-framework-nr2x3 Configuration
inspiring-cerf-fh63p Configuration

})
]);
},
props: {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this needed? seems like a runtime type checking thing? should we just rely on static type checker with this sort of thing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the default way
https://vuejs.org/v2/guide/components-props.html#Prop-Validation

I think with typescript it would be Object as () => SomeType

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants