refactor: Update database.py #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelCurrin
commented
Jun 18, 2021
| def __init__(self, client, name, codec_options=None, write_concern=None): | ||
| """ """ |
There was a problem hiding this comment.
An empty docstring serves no purpose.
If your ide is complaining it is missing, put in a value but not an empty one.
MichaelCurrin
commented
Jun 18, 2021
montydb/database.py
Outdated
| if name.startswith("system."): | ||
| is_invaild = True | ||
| if not name: | ||
| raise errors.OperationFailure("Invalid collection name - it may not be blank") |
There was a problem hiding this comment.
Instead of collapsing errors together as one, have 3 cases where you raise the error with a specific message for the user and show the name of the collection to help debugging too
Also invalid was spelt incorrectly
MichaelCurrin
changed the title
Remove whitespace too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.