Fix amount require

davidliudev · Sep 25, 2023 · cf28692 · cf28692
1 parent 7ad70fa
commit cf28692
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/contracts/v2/crossspace_content_v2.sol b/contracts/v2/crossspace_content_v2.sol
@@ -100,6 +100,7 @@ contract CrossSpaceShareContentV2 is Ownable {
 
         uint256 supply = sharesSupply[author][subject];
         require(supply >= amount, "Cannot sell more than the shares supply");
+        require(supply > amount, "Cannot sell the last share");
         uint256 price = getPrice(supply - amount, amount);
         uint256 protocolFee = price * protocolFeePercent / PERCENT_BASE;
         uint256 subjectFee = price * subjectFeePercent / PERCENT_BASE;

diff --git a/contracts/v2/crossspace_user_v2.sol b/contracts/v2/crossspace_user_v2.sol
@@ -84,6 +84,7 @@ contract CrossSpaceShareUserV2 is Ownable {
         require(msg.sender == parentProtocolAddress, "Caller is not the parent protocol");
 
         uint256 supplyInWei = sharesSupplyInWei[author];
+        require(supplyInWei > 0 || author == sender, "Only the shares' subject owner can buy the first share");
         uint256 price = getPrice(supplyInWei, amountInWei);
         uint256 protocolFee = price * protocolFeePercent / PERCENT_BASE;
         uint256 subjectFee = price * subjectFeePercent / PERCENT_BASE;
@@ -108,6 +109,7 @@ contract CrossSpaceShareUserV2 is Ownable {
 
         uint256 supplyInWei = sharesSupplyInWei[author];
         require(supplyInWei >= amountInWei, "Cannot sell exceeding shares supply");
+        require(supplyInWei > amountInWei, "Cannot sell the last share");
         uint256 price = getPrice(supplyInWei - amountInWei, amountInWei);
         uint256 protocolFee = price * protocolFeePercent / PERCENT_BASE;
         uint256 subjectFee = price * subjectFeePercent / PERCENT_BASE;