Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update ngx-meta desc #266

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Conversation

davidlj95
Copy link
Owner

@davidlj95 davidlj95 commented Feb 1, 2024

Social card eventuall was ending with (and . Now it's great!

index

Color can't be set to theme's color until insider feature gets released

Copy link
Owner Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

Copy link

github-actions bot commented Feb 1, 2024

📦 Bundle size (Angular v17)

Git ref: aa29578

Module file Size Base size Difference
ngx-meta-core.mjs 2846 bytes (2.8KiB) 2846 bytes (2.8KiB) No change
ngx-meta-json-ld.mjs 226 bytes (226B) 226 bytes (226B) No change
ngx-meta-open-graph.mjs 888 bytes (888B) 888 bytes (888B) No change
ngx-meta-routing.mjs 839 bytes (839B) 839 bytes (839B) No change
ngx-meta-standard.mjs 784 bytes (784B) 784 bytes (784B) No change
ngx-meta-twitter-card.mjs 501 bytes (501B) 501 bytes (501B) No change
Total 6084 bytes (6.0KiB) 6084 bytes (6.0KiB) No change

Copy link

github-actions bot commented Feb 1, 2024

📦 Bundle size (Angular v15)

Git ref: aa29578

Module file Size Base size Difference
ngx-meta-core.mjs 3250 bytes (3.2KiB) 3250 bytes (3.2KiB) No change
ngx-meta-json-ld.mjs 392 bytes (392B) 392 bytes (392B) No change
ngx-meta-open-graph.mjs 1232 bytes (1.3KiB) 1232 bytes (1.3KiB) No change
ngx-meta-routing.mjs 1015 bytes (1015B) 1015 bytes (1015B) No change
ngx-meta-standard.mjs 901 bytes (901B) 901 bytes (901B) No change
ngx-meta-twitter-card.mjs 661 bytes (661B) 661 bytes (661B) No change
Total 7451 bytes (7.3KiB) 7451 bytes (7.3KiB) No change

Copy link

github-actions bot commented Feb 1, 2024

📦 Bundle size (Angular v16)

Git ref: aa29578

Module file Size Base size Difference
ngx-meta-core.mjs 3250 bytes (3.2KiB) 3250 bytes (3.2KiB) No change
ngx-meta-json-ld.mjs 392 bytes (392B) 392 bytes (392B) No change
ngx-meta-open-graph.mjs 1232 bytes (1.3KiB) 1232 bytes (1.3KiB) No change
ngx-meta-routing.mjs 1015 bytes (1015B) 1015 bytes (1015B) No change
ngx-meta-standard.mjs 901 bytes (901B) 901 bytes (901B) No change
ngx-meta-twitter-card.mjs 661 bytes (661B) 661 bytes (661B) No change
Total 7451 bytes (7.3KiB) 7451 bytes (7.3KiB) No change

@@ -1,4 +1,4 @@
# Hello World! 👋
# Hello World!
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems social cards don't like emojis

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even if using :: syntax (ie: :wave:)

@davidlj95 davidlj95 merged commit f3508c4 into main Feb 1, 2024
14 checks passed
@davidlj95 davidlj95 deleted the stacked/docs-update-ngx-meta-desc branch February 1, 2024 16:53
@davidlj95 davidlj95 linked an issue Feb 1, 2024 that may be closed by this pull request
Copy link

🎉 This PR is included in version 1.0.0-alpha.39 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add docs
1 participant