Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module installation fails #3

Open
teobais opened this issue Oct 31, 2015 · 12 comments
Open

Module installation fails #3

teobais opened this issue Oct 31, 2015 · 12 comments

Comments

@teobais
Copy link
Contributor

teobais commented Oct 31, 2015

Hello,

seems hat there's an installation issue when running npm install nw-shot :

image

I'm on Windows 7 x64 and the npm-debug.log file is sent to your personal mail account.

@mikemaccana
Copy link

Getting the same thing here, using OS X, on the current stable node 4.2.1:

> nw-shot@4.2.0 postinstall /Users/mike/Documents/Conference Talks/burn-everything-down/node_modules/nw-shot
> install-nw

/Users/mike/Documents/Conference Talks/burn-everything-down/node_modules/install-nw/cmd.js:121
  version = [v.major, v.minor, v.patch].join('.');
              ^

TypeError: Cannot read property 'major' of null
    at down (/Users/mike/Documents/Conference Talks/burn-everything-down/node_modules/install-nw/cmd.js:121:15)
    at init (/Users/mike/Documents/Conference Talks/burn-everything-down/node_modules/install-nw/cmd.js:72:11)
    at Object.<anonymous> (/Users/mike/Documents/Conference Talks/burn-everything-down/node_modules/install-nw/cmd.js:41:10)
    at Module._compile (module.js:435:26)
    at Object.Module._extensions..js (module.js:442:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:311:12)
    at Function.Module.runMain (module.js:467:10)
    at startup (node.js:134:18)
    at node.js:961:3

@davidmarkclements
Copy link
Owner

Hmm they may have changed the url scheme again - will look into

@Empereol
Copy link

Empereol commented Dec 1, 2015

Is there any progress on this? I'm also getting the same error.

@the-simian
Copy link

Came here to report this very issue
nw

npm version 3.3.12
node version 5.5.0

@davidmarkclements
Copy link
Owner

hey @the-simian - what OS & what node version - I just tried to reproduce on OS X with node v5.5.0 and I'm not able to reproduce the problem

@the-simian
Copy link

The OS is windows 10. But i also confirmed it on Windows 7.

Hey, interestingly I'm generally experiencing postinstall script issues with packages like this, and others since npm changed to the nondeterministic way of doing it. Here is a similar situation on another similar module: FWeinb/node-webkit-screenshot#14

I was able to get a fix on that module by (in the postinstall script) cd'ing into one directory down first. I'm still actively looking into all this, so maybe I'll more later.

@davidmarkclements
Copy link
Owner

ah right right - good call - I switched back to npm2 for speed reasons

this issue is probably to do with the flat structure vs tree structure

@the-simian
Copy link

Yeah I am considering it as well, though I was able to get improved speeds by npm set progress=false

@davidmarkclements
Copy link
Owner

yah I head about that - haven't tried it yet

On Fri, Jan 29, 2016 at 8:35 PM, Jesse Harlin notifications@github.com
wrote:

Yeah I am considering it as well, though I was able to get improved speeds
by `npm set progress=false'


Reply to this email directly or view it on GitHub
#3 (comment)
.

David Mark Clements Ltd is a company registered in Northern Ireland.
Registered number: NI617728. Registered office: Unit 22a, Pennybridge
Industrial Estate,
Ballymena, Antrim, BT42 3HB

@duereg
Copy link

duereg commented Jan 30, 2016

Having the same issue on OSX, with node 4.2.4, npm 3.5.3

@the-simian
Copy link

hey I wanted to pop in and add, that I didn't end up getting this one to work, but we were able to solve postInstall script errors in a similar project by adding a cd to the right directory first.

see here: FWeinb/node-webkit-screenshot#15

I didn't dig long enough into this module to see if the fix is the same, but that might be useful.

@KJTsanaktsidis
Copy link

I was able to make this install by adding "nw" : "0.12.3" to the root of our package.json file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants