Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PreferencesWindow: code style, Gtk4 prep #169

Merged
merged 3 commits into from Feb 1, 2023

Conversation

danirabbit
Copy link
Collaborator

Clean up and Gtk 4 prep

  • Use default size so we don't hardcode a minimum size
  • Granite.Dialog already hides the close button, so this allows closing with esc
  • Can't set our own window position in Gtk4, should center parent anyways
  • Remove a lot of unnecessary properties from the switcher. Halign does what we need
  • Box instead of Grid
  • Use add_button from dialog instead of creating another action area
  • Remove unnecessary cast

@davidmhewitt davidmhewitt merged commit d00e265 into davidmhewitt:main Feb 1, 2023
@danirabbit danirabbit deleted the prefswindow-cleanup branch February 1, 2023 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants