Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dialogs: connect to response, use present #178

Merged
merged 5 commits into from Feb 2, 2023
Merged

Dialogs: connect to response, use present #178

merged 5 commits into from Feb 2, 2023

Conversation

danirabbit
Copy link
Collaborator

@danirabbit danirabbit commented Feb 2, 2023 •
edited

  • dialog.run () doesn't exist in Gtk 4
  • Since we remove a show_all in the file select dialog, do things there to fix showing the widgets
  • While we're touching the file select dialog, fix margins, parent (they're weird values, but I promise it renders correctly)

@davidmhewitt davidmhewitt merged commit b5f1aba into main Feb 2, 2023
@davidmhewitt davidmhewitt deleted the dialog-present branch February 2, 2023 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidmhewitt davidmhewitt davidmhewitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danirabbit @davidmhewitt