New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TorrentListBox: make placeholder internal #190

Merged

davidmhewitt merged 1 commit into main from listbox-placeholder

Feb 6, 2023

Collaborator

danirabbit commented Feb 5, 2023

Fixes some bugs with placeholder text being incorrect or placeholder showing when there are torrents

Make placeholder stack internal to the TorrentListBox
Use set_placeholder to make sure we only show placeholders when the listbox is actually empty
Use fewer placeholders and just update the text
Fix has_visible_children


          TorrentListBox: make placeholder internal

danirabbit requested a review from davidmhewitt

February 5, 2023 16:52

davidmhewitt approved these changes

View reviewed changes

davidmhewitt merged commit 2e22a8b into main

davidmhewitt deleted the listbox-placeholder branch

February 6, 2023 14:52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment