Add destroyCf goal that deletes CloudFormation stack. #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidmoten
reviewed
Jul 9, 2020
| long t = System.currentTimeMillis(); | ||
|
|
||
| while (true) { | ||
| List<Stack> stacks; | ||
| try { | ||
| stacks = cloudFormationClient.describeStacks(describeRequest).getStacks(); | ||
| } catch (AmazonCloudFormationException e) { | ||
| log.warn(e.getMessage()); |
There was a problem hiding this comment.
Why have you removed the warning?
There was a problem hiding this comment.
When stack is destroyed, in my tests it always throws exception here saying that stack is not found - being a bit misleading because this is exactly what was meant to happen. Perhaps it could be changed to info?
There was a problem hiding this comment.
info sounds fine if you could make that change
davidmoten
approved these changes
Jul 10, 2020
|
I've deployed this change to Maven Central in 0.2.26. |
|
Fantastic, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to use this plugin for running integration tests, where in pre-integration-test phase stack is created and in post-integration-test stack is destroyed.
This PR adds a goal to destroy CloudFormation stack.