Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected coverage with bounding box of the world #34

Closed
k-mack opened this issue Aug 23, 2018 · 3 comments
Closed

Unexpected coverage with bounding box of the world #34

k-mack opened this issue Aug 23, 2018 · 3 comments

Comments

@k-mack
Copy link

k-mack commented Aug 23, 2018

I might be using this incorrectly, but when I do

double topLeftLat = 90d
double topLeftLon = -179d
double bottomRightLat = -90d
double bottomRightLon = 180d
Coverage c = GeoHash.coverBoundingBox(topLeftLat, topLeftLon, bottomRightLat, bottomRightLon, 1);

I would have expected c.getHashes() to contain the 32 single-character Geohashes (i.e., 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, b, c, d, e, f, g, h, j, k, m, n, p, q, r, s, t, u, v, w, x, y, z).

Instead, it contains only 0, 2, 8, b.

@k-mack
Copy link
Author

k-mack commented Aug 23, 2018

#25 would fix this.

@ajeyaraj
Copy link

ajeyaraj commented Nov 9, 2020

Hi Guys, Can you please fix this? I am facing this issue and looking for a solution. Thanks in advance.

davidmoten pushed a commit that referenced this issue Sep 5, 2021
* Fix wrong coverage around antimeridian and other coverage issues (see #25 and #34)

* Remove testCoverBoundingBoxPreconditionLon

Co-authored-by: Guilhem Lucas <guilhem.lucas@actility.com>
@guilhem-lk
Copy link
Contributor

Hi @davidmoten this could be closed since #49 merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants