Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Osgi bundles #6

Merged
merged 3 commits into from
Jun 4, 2020
Merged

Osgi bundles #6

merged 3 commits into from
Jun 4, 2020

Conversation

badfish69
Copy link

Update packaging to generate OSGI manifest data, to better support deployment in OSGI environments.

Sorry - take #2 on this pull request, there was a missing commit.

The first commit is simple enough, it just uses the maven-bundle-plugin to add the OSGI headers to the manifest of each jar file.

The second commit is more of a breaking change. OSGI does not like multiple bundles (jar files) providing classes from the same package namespace. In this case, you're using the same namespace for the odata-client-msgraph and odata-client-msgraph-client-builder packages (com.github.davidmoten.msgraph). I've moved the builder classes into their own namespace, but this might have implications for client code if people have used any of the builder classes directly.

@codecov-commenter
Copy link

codecov-commenter commented Jun 2, 2020

Codecov Report

Merging #6 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #6   +/-   ##
=======================================
  Coverage   57.00%   57.00%           
=======================================
  Files          86       86           
  Lines        3863     3863           
  Branches      242      242           
=======================================
  Hits         2202     2202           
  Misses       1582     1582           
  Partials       79       79           
Impacted Files Coverage Δ
...va/com/github/davidmoten/msgraph/beta/MsGraph.java 0.00% <ø> (ø)
...in/java/com/github/davidmoten/msgraph/MsGraph.java 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 438d0d6...57f784f. Read the comment docs.

odata-client-runtime/pom.xml Show resolved Hide resolved
odata-client-runtime/pom.xml Show resolved Hide resolved
@davidmoten davidmoten merged commit 5ef6b27 into davidmoten:master Jun 4, 2020
@davidmoten
Copy link
Owner

Thanks @badfish69, nice to have you helping out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants