-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to set arbitrary Integer values to FetchSize #79
Allow to set arbitrary Integer values to FetchSize #79
Conversation
Rework the fetchSize parameter to allow the specification of negative integers like Integer.MIN_VALUE, which is needed in some typoes of queries. See https://dev.mysql.com/doc/connector-j/5.1/en/connector-j-reference-implementation-notes.html Closes davidmoten#78
Thanks for the PR. Why change fetchSize from I also haven't understood what is the difference between setting |
I just read
On this basis I would continue using 0 for not set, allow |
for mysql it looks like
|
Great! if it could be merged soon it would be very appreciated. |
It seems that drivers take some latitude with If we were on Java 8, I'd have used an |
In other words, if we go with "0 is default, |
I'm happy with your argument. I'll merge and release. |
released to Maven Central 0.7.7 |
Rework the fetchSize parameter to allow the specification of negative integers
like Integer.MIN_VALUE, which is needed in some typoes of queries.
See https://dev.mysql.com/doc/connector-j/5.1/en/connector-j-reference-implementation-notes.html
Closes #78