Fix race condition with disposal in MemberSingle.tryEmit #59
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #58 there was a race condition where all
Observer
s could be disposed by the time the code hits this line inMemberSingle.tryEmit
:rxjava2-jdbc/rxjava2-pool/src/main/java/org/davidmoten/rx/pool/MemberSingle.java
Line 276 in 841bda1
If all observers have been disposed then
x.observers[index]
throws anArrayIndexOutOfBoundsException
.The fix is to check the active count of observers.
I've also fixed the message of a
Precondtions
check, added some comments, and moved another comment to a better place.