Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look into setting a maximum password length to prevent DOS attacks #6

Closed
davidmurdoch opened this issue Sep 19, 2013 · 6 comments · Fixed by #14
Closed

Look into setting a maximum password length to prevent DOS attacks #6

davidmurdoch opened this issue Sep 19, 2013 · 6 comments · Fixed by #14

Comments

@davidmurdoch
Copy link
Owner

DOS attacks via long passwords will probably be making their rounds (again). http://www.tomsguide.com/us/django-long-password-security,news-17557.html

I'm thinking about setting a default max-length of maybe 4096 bytes. This max-password length would be configurable.

silentmatt added a commit to silentmatt/easy-pbkdf2 that referenced this issue Oct 23, 2017
@aintabb
Copy link

aintabb commented Oct 23, 2020

I can grab this one if no one is working currently?

@davidmurdoch
Copy link
Owner Author

go for it!

@davidmurdoch
Copy link
Owner Author

I actually just noticed there is already a PR for this feature. I'm just going to merge that :-)

@aintabb
Copy link

aintabb commented Oct 23, 2020

@davidmurdoch Oh, I was so close to get a t-shirt. Thanks anyway :)

@davidmurdoch
Copy link
Owner Author

davidmurdoch commented Oct 23, 2020

Ah, didn't realize it was for a hacktoberfest. If you are familiar with HTTP basic auth, you could try your hand at trufflesuite/ganache#418

@aintabb
Copy link

aintabb commented Oct 24, 2020

@davidmurdoch I don't have experience with HTTP basic auth, but I think i can give it a shot. Do you have any resource that I can check or any starter guide for ganache-core project?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants