Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:Support keymap for vim mode #73

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

GodlessLiu
Copy link

I noticed that the current vim mode does not support custom keyboard mapping
For example:
I want to setj jin vscode to turn insert mode to normal mode, but I found that the current editor vim option does not support.

stay https://github.com/replit/codemirror-vim Key maps are already supported. Based on this, I added vim settings. the follow is the interface

interface VimOptions {
  map?: MapOption[]    、
  unmap?: UnMapOption[]
  open?: boolean
}
interface MapOption {
  before?: string
  after?: string
  mode?: string
}
interface UnMapOption {
  before?: string
  mode?: string
}

@davidmyersdev
Copy link
Owner

Hey, @GodlessLiu. I appreciate the PR, but it looks like there are some CI failures. Would you mind addressing those? Also, I'm not necessarily opposed to adding Prettier config, but it should really be a separate PR from the Vim change. Thanks!

@GodlessLiu
Copy link
Author

Hey, @GodlessLiu. I appreciate the PR, but it looks like there are some CI failures. Would you mind addressing those? Also, I'm not necessarily opposed to adding Prettier config, but it should really be a separate PR from the Vim change. Thanks!

ok! I will have a try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants