Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance improvements, separate commands for inverse filter, in place filter #45

Merged
merged 7 commits into from
Apr 10, 2017

Conversation

poma
Copy link
Contributor

@poma poma commented Apr 9, 2017

This PR contains major performance improvements and 2 new functions:

  • invert_search is promoted to a command parameter and separate commands are created for include and exclude filters
  • an option for in place replacement

I saw that you previously removed in place filtering. I don't know your reasons but feel free to include only performance commits from this PR. I've made sure that each commit is separate and doesn't introduce complexity, in place editing is added with only few lines of code.

@davidpeckham davidpeckham merged commit ae050a6 into davidpeckham:master Apr 10, 2017
@davidpeckham
Copy link
Owner

Poma, thank you for these useful improvements.

gene1wood added a commit to gene1wood/sublime-filterlines that referenced this pull request Mar 15, 2023
This adds in the changes to `invert_search` made back in davidpeckham#45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants