Two select_triplets functions with performance improvement #59
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi David,
I added two select_triplets functions and here is a quick summary of the changes.
The latest implementation improves another 15% over the first one with only distance matrix.
Please review the the changes, especially #3 that might not have the same rules as the original one.
These changes do improve the performance by almost 3x compared to the original one when running on my computer.
Thanks,
Scott Hong