Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature | Anki Mode] 594 - Combine Reading + Meaning #664

Merged

Conversation

tarcisiotm
Copy link
Contributor

@tarcisiotm tarcisiotm commented Sep 15, 2023

This is a quality of life feature for the Anki Mode. When using Anki Mode with back-to-back, it feels like doing the same review twice. To address that, combining meaning and reading into one review was implemented.

This feature is especially valuable to people who turned to Anki Mode in order to burn reviews faster be on top of their review queues. Having this feature makes burning the reviews a lot faster. Also important to note, this feature is optional and disabled by default, even if Anki Mode is already enabled.

  • added the ability to combine meaning and reading reviews on Anki Mode
  • added option to settings screen, which is only shown when Anki Mode is enabled, option is always false by default, and toggled of when Anki mode is disabled / enabled
  • reading / meaning order shown respects the configuration set when back-to-back is enabled
  • this feature works by making use of "back-to-back" reviews built-in functionality, so any time a non-radical review is marked correct, it takes the "next task" and marks that as correct as well.

Please let me know if there are any concerns I should address before this can be merged in.

I have been testing for a couple of weeks now, and I can say this makes it an even nicer experience for Anki Mode.

Issue: #594

- added the ability to combine meaning and reading reviews on Anki Mode
- added option to settings screen, which is only shown when Anki Mode is enabled
- reading / meaning order shown respects the configuration set when back-to-back is enabled
- this feature works by making use of "back-to-back" reviews built-in functionality, so any time a non-radical review is marked correct, it takes the "next task" and marks that as correct as well.
@davidsansome davidsansome merged commit 0546cef into davidsansome:master Sep 29, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants