Sync with ZengoX master (ZenGo-X#18)

* Fix broken link to threshold signatures article (ZenGo-X#185)

* Map errors instead of expecting

* fix check warnings

---------

Co-authored-by: Evan Tedesco <Evantedesco@gmail.com>
Co-authored-by: 1xstj <106580853+1xstj@users.noreply.github.com>

README.md

@@ -11,7 +11,7 @@ Threshold ECDSA includes two protocols:
 -   Signing for using the secret shares to generate a signature.
 
 ECDSA is used extensively for crypto-currencies such as Bitcoin, Ethereum (secp256k1 curve), NEO (NIST P-256 curve) and much more.
-This library can be used to create MultiSig and ThresholdSig crypto wallet. For a full background on threshold signatures please read our Binance academy article [Threshold Signatures Explained](https://www.binance.vision/security/threshold-signatures-explained).
+This library can be used to create MultiSig and ThresholdSig crypto wallet. For a full background on threshold signatures please read our Binance academy article [Threshold Signatures Explained](https://academy.binance.com/en/articles/threshold-signatures-explained).
 
 ## Library Introduction
 The library was built with four core design principles in mind:

src/lib.rs

@@ -20,9 +20,10 @@
 
 pub mod protocols;
 pub mod utilities;
-pub use protocols::multi_party_ecdsa::gg_2020::state_machine::traits::MessageRoundID;
 use std::fmt;
 
+pub use protocols::multi_party_ecdsa::gg_2020::state_machine::traits::MessageRoundID;
+
 #[derive(Copy, PartialEq, Eq, Clone, Debug)]
 pub enum Error {
     InvalidKey,

src/protocols/multi_party_ecdsa/gg_2020/state_machine/sign/fmt.rs

@@ -9,6 +9,7 @@ impl fmt::Debug for super::OfflineStage {
 }
 
 #[derive(Debug)]
+#[allow(dead_code)]
 pub struct OfflineStageProgress {
     round: OfflineR,
 
@@ -120,6 +121,7 @@ impl fmt::Debug for ReceivedMessages {
 }
 
 #[derive(Debug)]
+#[allow(dead_code)]
 pub struct OutgoingMessages {
     len: usize,
 }

src/protocols/multi_party_ecdsa/gg_2020/state_machine/sign/rounds.rs

@@ -651,6 +651,7 @@ impl Round6 {
 }
 
 #[derive(Clone)]
+#[allow(dead_code)]
 pub struct CompletedOfflineStage {
     i: u16,
     local_key: LocalKey<Secp256k1>,

src/protocols/two_party_ecdsa/lindell_2017/party_two.rs

@@ -82,7 +82,9 @@ pub struct PartialSig {
 pub struct Party2Private {
     x2: Scalar<Secp256k1>,
 }
+
 #[derive(Debug)]
+#[allow(dead_code)]
 pub struct PDLchallenge {
     pub c_tag: BigInt,
     pub c_tag_tag: BigInt,