Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UTF-8 encoding support #273

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

UTF-8 encoding support #273

wants to merge 3 commits into from

Conversation

19z
Copy link

@19z 19z commented May 3, 2022

Now you can use text in other languages.

qrcode.makeCode("你好 こんにちは 여보세요");

@jp-ed
Copy link

jp-ed commented Jun 13, 2022

Nice work. This also fixes an overflow issue when using emojis.

qrcode.makeCode("🖤🌹");

@anka
Copy link

anka commented Aug 4, 2022

@19z Actually, it does not work in combination with VCARD. If I create a valid VCARD the umlaute "ö,Ö,ä,Ä,..." are not shown correctly. However, if I create a QR code just for a simple text line like "Österreich" it works pretty fine. Do you have any suggestions on that?

Example:

BEGIN:VCARD
VERSION:4.0
N:LÄstname;FirstNäme;;Title;
FN:Title FirstNäme LÄstname
END:VCARD

IMG_52C655939EE2-1

@19z
Copy link
Author

19z commented Aug 4, 2022

@19z Actually, I does not work in combination with VCARD. If I create a valid VCARD the umlaute "ö,Ö,ä,Ä,..." are not shown correctly. However, if I create a QR code just for a simple text line like "Österreich" it works pretty fine. Do you have any suggestions on that?

Example:

BEGIN:VCARD
VERSION:4.0
N:LÄstname;FirstNäme;;Title;
FN:Title FirstNäme LÄstname
END:VCARD

IMG_52C655939EE2-1

I scanned it using another scanning tool and parsed the original text as you entered it. It doesn't seem to be a problem with the generator.

@anka
Copy link

anka commented Aug 4, 2022

@19z Ok, thanks for that. I did use an iPhone 12 Pro with iOS 15.4.1 and its native QR code scanning feature.

@anka
Copy link

anka commented Aug 5, 2022

@19z found a solution. Either use VERSION:3.0 or add the property CHARSET=UTF-8 to each appropriate line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants