Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug 🐞]: change pacman package dependency #37

Closed
Reverier-Xu opened this issue Jun 13, 2022 · 8 comments · Fixed by #40
Closed

[Bug 🐞]: change pacman package dependency #37

Reverier-Xu opened this issue Jun 13, 2022 · 8 comments · Fixed by #40
Assignees

Comments

@Reverier-Xu
Copy link

Reverier-Xu commented Jun 13, 2022

change pacman package required libappindicator-sharp dependency to optional 🐞

hi, i'd like you to change the libappindicator-sharp dependency in the package to an optional dependency.

Describe the bug
libappindicator-sharp package in AUR is no longer maintained, and it is not necessary for kuro.

@davidsmorais davidsmorais self-assigned this Jun 20, 2022
@davidsmorais davidsmorais linked a pull request Jun 21, 2022 that will close this issue
@davidsmorais davidsmorais reopened this Jun 21, 2022
@davidsmorais
Copy link
Owner

Hey @Reverier-Xu 👋

I've recently updated electron and electron-builder to their latest version on our most recent release. Can you please check if this dependency is still being used ?

If it is, then I guess this dependency comes from one of those packages and there's nothing I can really do about it 😢

@Reverier-Xu
Copy link
Author

Hi, the newest release solved the dependency problem but ... it seems not working as well.

image

Could you update the pacman's PKGBUILD file to this repository? maybe i can help.

@Reverier-Xu
Copy link
Author

The electron version 19 is too high even for Arch Linux ...

image

it is recommended that we just publish a PKGBUILD file on aur.archlinux.org instead of build a binary package. Users could install kuro from paru/yay or other AUR package helpers. PKGBUILD is a simple pack script, we can pack the appimage as a pacman package in PKGBUILD, that solves most problems.

the appimage PKGBUILD file may looks like this:

# Maintainer: ???
pkgname=kuro-appimage
pkgver=8.1.1
pkgrel=1
pkgdesc="An elegant Microsoft ToDo desktop client for Linux (a fork of Ao)"
arch=("x86_64")
url="https://github.com/davidsmorais/kuro"
license=("unknown")
_pkgname="Kuro-${pkgver}.AppImage"
noextract=(${_pkgname})
options=("!strip")
provides=("kuro")
optdepends=()
source=("https://github.com/davidsmorais/kuro/releases/download/v${pkgver}/${_pkgname}")
sha512sums=("755bd884a8bd44ca383205fe9c7836a42f6e5cfce9289d0b5dbaff924404773d02110b9da4332c0556ab1924f0e5a1e1ea4a2a2f142e48e86528ebb626814038")

_installdir=/opt/appimages

prepare() {
    cd ${srcdir}
    chmod a+x ${_pkgname}
    ${srcdir}/${_pkgname} --appimage-extract >/dev/null
    sed -i "s+AppRun+env DESKTOPINTEGRATION=no ${_installdir}/Kuro.AppImage+" "squashfs-root/kuro.desktop"
    sed -i "s+Icon=kuro+Icon=kuro-appimage+" "squashfs-root/kuro.desktop"
}

package() {
    install -Dm755 ${_pkgname} "${pkgdir}/${_installdir}/Kuro.AppImage"
    install -Dm644 "squashfs-root/usr/share/icons/hicolor/1024x1024/apps/kuro.png" "${pkgdir}/usr/share/icons/hicolor/1024x1024/apps/kuro-appimage.png"
    install -Dm644 "squashfs-root/kuro.desktop" "${pkgdir}/usr/share/applications/kuro-appimage.desktop"
}

so that you can just publish appimage then update the PKGBUILD, all things will be done.

@Reverier-Xu
Copy link
Author

Ahh...it seems that electron 19 has broken this app...
the AppImage does not work too...

@davidsmorais
Copy link
Owner

davidsmorais commented Jun 21, 2022

@Reverier-Xu , thanks for the tips & feedback 👍
there's already an open issue for AUR package (#22). I don't have any machines running any Arch based distros, so would be great if you could help 👍
I'm also releasing a new version with electron 18.3.4 as 19.0.5 was released yesterday 😓

EDIT: Please give it a go with version 8.1.3

@Reverier-Xu
Copy link
Author

Hi, version 8.1.3 still not works (both pacman and appimage).

image

i think the electron is not necessary to upgrade to the newest version. AppImage will pack all dependencies so that we don't need to worry about it on any linux distros.

if you want to upgrade electron, there is a lot work to do.

@davidsmorais
Copy link
Owner

I'm sorry, this is running fine in my machine, even after resetting the settings.

Can you please try and do a rm -rf ~/.config/Kuro ?

@Reverier-Xu
Copy link
Author

I'm sorry, this is running fine in my machine, even after resetting the settings.

Can you please try and do a rm -rf ~/.config/Kuro ?

ohh, it seems ok, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants