-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature 🚀]: Use system electron for Arch Linux #70
Comments
Hi @skbeh, I am the maintainer of the kuro AUR package. Is kuro-electron your package? I believe it does what you want. However, there are some things I wanted to discuss.
These quotes suggest that shipping (or not) is an option, not an obligation.
So, the best way to do it is to decide something and do it on the original package.
Maybe @davidsmorais can chime in on this. |
@bilal-tasdelen kuro-electron is not my package. |
I agree with the |
@bilal-tasdelen This is an example: https://github.com/skbeh/kuro |
@skbeh I copied my package to |
@bilal-tasdelen I may not have enough time to keep it updated. It would be better to add me to co-maintainers. |
@skbeh I migrated the package to your PKGBUILD. I can add you as co-maintainer if you give me your AUR username. One issue: Themes do not seem to work with compiled Kuro, but works fine with kuro-bin. |
@bilal-tasdelen @skbeh Themes are now broken on both Happy to help with debugging/testing. |
Actually, Microsoft To-do has its own dark theme, which can be enabled in setting as a workaround. |
@bilal-tasdelen Preload js failed probably because of https://www.electronjs.org/de/docs/latest/breaking-changes#default-changed-renderers-without-nodeintegration-true-are-sandboxed-by-default. |
@skbeh I am getting following error during
Edit: Could this be relevant? |
@bilal-tasdelen Fixed. |
Thanks for this guys 👋 I've been away for the weekend and Arch/AUR isn't really something I can do much about 😅 |
@bilal-tasdelen I've tested both |
@bilal-tasdelen @davidsmorais Maybe we should consider moving to electron 19 now, because electron 18 is EOL since 3 months ago and it is orphan in the AUR. |
Is your feature request related to a problem? Please describe.
Currently the pacman package ships an electron, which violates Electron package guidelines of Arch Linux and wastes space.
Describe the solution you'd like
kuro.asar
and shell wrapper in the Arch package, name it askuro-bin
and submit the package to AUR. (It seems that it runs properly on https://archlinux.org/packages/community/x86_64/electron/)kuro
package in AUR be built from source.The text was updated successfully, but these errors were encountered: