Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix retain cycle, channel should not retain socket #37

Merged

Conversation

NilsLattek
Copy link
Contributor

There is a retain cycle, because a channel holds a strong reference to the socket and the socket has an array of channels as a strong reference.
In order to fix this we can make the channel hold a weak reference to the socket.

@davidstump davidstump merged commit b1817e0 into davidstump:master Jun 6, 2016
@davidstump
Copy link
Owner

Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants