adds href to link #519
Closed
adds href to link #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After investigating more this seems to be conflicting with angular. Angular seems to have issues with links that do not have an href. https://jsfiddle.net/5ssyyw2c/ |
|
Did you check whether this change is still working with Knockout JS or without both frameworks? |
|
Hello, I'm experiencing the same issue. Can any one tell me how to solve this ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When clicking on the links the checkboxes do not get updated. I noticed the event chain just stops. After manual debugging for an hour or so I narrowed in on the issue being with Angular.
The only solution that I found that works is to add an href to the links.
I understand this is more on angularsj side and not bootstrap-multiselects. I just wanted to submit a PR just in case anyone else runs up against this problem.