Skip to content

Commit

Permalink
* progmodes/ebrowse.el (ebrowse-display-member-buffer): Avoid
Browse files Browse the repository at this point in the history
	using with-output-to-temp-buffer, which clobbers local vars.
  • Loading branch information
Chong Yidong committed Jul 11, 2006
1 parent 363a844 commit 2e888d7
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 17 deletions.
5 changes: 5 additions & 0 deletions lisp/ChangeLog
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
2006-07-11 Chong Yidong <cyd@stupidchicken.com>

* progmodes/ebrowse.el (ebrowse-display-member-buffer): Avoid
using with-output-to-temp-buffer, which clobbers local vars.

2006-07-11 Stefan Monnier <monnier@iro.umontreal.ca>

* progmodes/compile.el (compilation-error-regexp-alist-alist):
Expand Down
34 changes: 17 additions & 17 deletions lisp/progmodes/ebrowse.el
Original file line number Diff line number Diff line change
Expand Up @@ -2734,24 +2734,24 @@ means the member buffer is standalone. CLASS is its class."
;; is on if not specified as an argument.
(unless class
(setq class (ebrowse-tree-at-point)))
(with-output-to-temp-buffer ebrowse-member-buffer-name
(save-excursion
(set-buffer standard-output)
(save-selected-window
(if temp-buffer
(pop-to-buffer temp-buffer)
(pop-to-buffer (get-buffer-create ebrowse-member-buffer-name))
;; If new buffer, set the mode and initial values of locals
(unless temp-buffer
(ebrowse-member-mode))
;; Set local variables
(setq ebrowse--member-list (funcall list class)
ebrowse--displayed-class class
ebrowse--accessor list
ebrowse--tree-obarray classes
ebrowse--frozen-flag stand-alone
ebrowse--tags-file-name tags-file-name
ebrowse--header header
ebrowse--tree tree
buffer-read-only t)
(ebrowse-redisplay-member-buffer)
(current-buffer)))))
(ebrowse-member-mode))
;; Set local variables
(setq ebrowse--member-list (funcall list class)
ebrowse--displayed-class class
ebrowse--accessor list
ebrowse--tree-obarray classes
ebrowse--frozen-flag stand-alone
ebrowse--tags-file-name tags-file-name
ebrowse--header header
ebrowse--tree tree
buffer-read-only t)
(ebrowse-redisplay-member-buffer)
(current-buffer))))


(defun ebrowse-member-display-p (member)
Expand Down

0 comments on commit 2e888d7

Please sign in to comment.