Skip to content

Commit

Permalink
Prefer "Bug#1234" in commit messages
Browse files Browse the repository at this point in the history
* .dir-locals.el (log-edit-mode): Don't rewrite Bug#,
as this isn't useful for Git.
* CONTRIBUTE: Suggest "Bug#1234" instead of "Fixes: debbugs:1234".
  • Loading branch information
eggert committed Apr 19, 2015
1 parent f4f1380 commit f2da220
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 10 deletions.
4 changes: 1 addition & 3 deletions .dir-locals.el
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,7 @@
(fill-column . 70)))
(c-mode . ((c-file-style . "GNU")))
(objc-mode . ((c-file-style . "GNU")))
(log-edit-mode . ((log-edit-rewrite-fixes
"[ \n](bug#\\([0-9]+\\))" . "debbugs:\\1")
(log-edit-font-lock-gnu-style . t)
(log-edit-mode . ((log-edit-font-lock-gnu-style . t)
(log-edit-setup-add-author . t)))
(change-log-mode . ((add-log-time-zone-rule . t)
(fill-column . 74)
Expand Down
11 changes: 4 additions & 7 deletions CONTRIBUTE
Original file line number Diff line number Diff line change
Expand Up @@ -42,12 +42,11 @@ in its message. Here is an example commit message (indented):
Deactivate shifted region

Do not silently extend a region that is not highlighted;
this can happen after a shift.
this can happen after a shift (Bug#19003).
* doc/emacs/mark.texi (Shift Selection): Document the change.
* lisp/window.el (handle-select-window):
* src/frame.c (Fhandle_switch_frame, Fselected_frame):
Deactivate the mark.
Fixes: bug#19003

The general format is as follows.

Expand Down Expand Up @@ -113,11 +112,9 @@ The general format is as follows.

Copyright-paperwork-exempt: yes

- If the commit fixes a bug, append a separate line

Fixes: bug#NNNN

where NNNN is the bug number.
- The commit message should contain "Bug#NNNNN" if it is related to
bug number NNNNN in the debbugs database. This string is often
parenthesized, as in "(Bug#19003)".

- In ChangeLog entries, there is no standard or recommended way to
identify revisions.
Expand Down

0 comments on commit f2da220

Please sign in to comment.