Updated build script to require Mac OS 10.9+ #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also added a note on the use of deprecated and non-working functions inside this experimental code block.
Since we’re on 10.9+, the method scrollerWidthForControlSize:scrollerStyle: is always available so the code that checks this is unnecessary. This also gets rid of the deprecated (and unused) call to scrollerWidth.
Since we’re on 10.9+, the checks for version and AppKit>=10.9 are unnecessary. This also gets rid of the deprecated (and unused) call to convertBaseToScreen. Additionally, a wrongfully placed #endif (introduced in c8a61d8) has been fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build script has been updated to reflect the fact that the build is only for Mac OS 10.9+
Removed/replaced deprecated methods and unnecessary version checks.
Also fixed a wrongfully placed
#endifinsrc/nsfns.m.