Updated Version 7 to address false positive

davidtauriello · Jul 30, 2018 · 7114548 · 7114548
1 parent 00e95e4
commit 7114548
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/dqc_us_rules/dqc-us-2018-V7-ruleset.zip b/dqc_us_rules/dqc-us-2018-V7-ruleset.zip
diff --git a/dqc_us_rules/source/us/2018/DQC_0071.xule b/dqc_us_rules/source/us/2018/DQC_0071.xule
@@ -18,14 +18,16 @@ rule-name-prefix DQC
 assert US.0071.7646 satisfied
 
 /** Count the number of revenue facts that are reported using the ProductOrServiceAxis **/
+
+/** Also need to take other dimensions out of alignment **/
 $count_values =count(list({@@concept in list(RevenueFromContractWithCustomerIncludingAssessedTax, RevenueFromContractWithCustomerExcludingAssessedTax, CostOfGoodsAndServicesSold) @srt:ProductOrServiceAxis = *}#Revenue));
 
 /**If there is only 1 fact and the default value is not reported then flag an error **/
 $count_values == 1 and (not exists({@srt:ProductOrServiceAxis = none}))
 
 
 message
-"The filing has  reported a value for the element {$Revenue.concept} with a value of {$Revenue} using the ProductOrServiceAxis. However, the only member used to disaggregate the total for {$Revenue.concept} was the member {$Revenue.dimension(ProductOrServiceAxis)}. If only one member is used on this axis then the filer should either:
+"The filing has  reported a value for the element {$Revenue.concept} with a value of {$Revenue} using the ProductOrServiceAxis. However, the only member used to disaggregate the total for {$Revenue.concept} was the member {$Revenue.dimension(srt:ProductOrServiceAxis)}. If only one member is used on this axis then the filer should either:
 
 1. Retag the filing using the element TypeOfRevenueExtensibleList/TypeOfCostGoodOrServiceExtensibleList with a value of {$Revenue.dimension(ProductOrServiceAxis)} and the member {$Revenue.dimension(ProductOrServiceAxis)} should be removed from the value as it represents the aggregate value of {$Revenue.concept}.
 

diff --git a/dqc_us_rules/source/us/2018/DQC_0076.xule b/dqc_us_rules/source/us/2018/DQC_0076.xule
@@ -13,11 +13,11 @@ rule-name-prefix DQC
 
 assert US.0076.7653 satisfied
 
-exists({@concept in list(RevenueRemainingPerformanceObligationPercentage, RevenueRemainingPerformanceObligation) @RevenueRemainingPerformanceObligationExpectedTimingOfSatisfactionStartDateAxis = *}#obligation)
+exists({@concept in list(RevenueRemainingPerformanceObligationPercentage, RevenueRemainingPerformanceObligation) @@RevenueRemainingPerformanceObligationExpectedTimingOfSatisfactionStartDateAxis = * @unit = *}#obligation)
 
 and 
 (
-	not exists({@RevenueRemainingPerformanceObligationExpectedTimingOfSatisfactionPeriod1 @RevenueRemainingPerformanceObligationExpectedTimingOfSatisfactionStartDateAxis = * @period = *})
+	  not exists({@concept = RevenueRemainingPerformanceObligationExpectedTimingOfSatisfactionPeriod1 @@RevenueRemainingPerformanceObligationExpectedTimingOfSatisfactionStartDateAxis = *  }#period_id)
 )
 
 
@@ -37,3 +37,4 @@ SEVERITY error
 
 rule-focus $obligation
 
+