Docs: Revise Redux component language #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From "smart" and "dumb" to "container" and "presentational". See revisions here: https://medium.com/@dan_abramov/smart-and-dumb-components-7ca2f9a7c7d0
README.md
Outdated
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| A fully accessible and flexible React modal built according [WAI-ARIA Authoring Practices](http://www.w3.org/TR/wai-aria-practices/#dialog_modal). | |||
|
|
|||
| This module provides a "smart" minimally styled component to wrap you "dumb" fully styled component. It provides the following features, while giving you complete control of the content: | |||
| This module provides a minimally styled "Container" component to wrap your fully-styled "Presentational" component. It provides the following features, while giving you complete control of the content: | |||
There was a problem hiding this comment.
👍 👍
Could we lowercase those words in quotation marks?
While we're at it, maybe we should provide a link to the article you mentioned, in case a reader doesn't know what these terms mean?
For presentational and container components
davidtheclark
approved these changes
Feb 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From "smart" and "dumb" to "container" and "presentational".
See revisions here: https://medium.com/@dan_abramov/smart-and-dumb-components-7ca2f9a7c7d0