Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows support #6

Merged
merged 2 commits into from
Jul 6, 2021
Merged

windows support #6

merged 2 commits into from
Jul 6, 2021

Conversation

davidtjones
Copy link
Owner

@davidtjones davidtjones commented Jul 6, 2021

This wasn't a terrible amount of work. Setting up python for development on windows is more difficult than anything in this branch. See #2.

Possible pain points:

  • libmelee doesn't use any kind of solid path scheme (pathlib, os.path.join, etc), so there are some perilous locations where a "/" is added to satisfy libmelee
  • this is my first shot at cross platform support. Nothing in the install is super complicated but I'm not sure what can wrong between different operating systems.
  • Additionally, is AppData/Roaming actually a good place? I'm not well versed in Windows paradigms.

Copy link
Collaborator

@cnkeats cnkeats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@cnkeats cnkeats merged commit 632bb95 into master Jul 6, 2021
@davidtjones davidtjones deleted the windows-support branch July 6, 2021 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants