Determine batch size from labels instead of inputs
#58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In `LRFinder._validate()`, batch size was determined by given `inputs` dynamically. However, `inputs` might not be tensors or list of tensors in some cases, and that makes it not able to determine batch size from `inputs.size()` or `inputs[0].size()`. In this revision, we change to code to determine batch size from `labels` since all loss functions expecting the `labels` to be a tensor (reviewed by @davidtvs). And it keeps the compatibility to work with non-full batch (e.g. when `drop_last` of a `DataLoader` is True).
|
/flake8-lint |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
LGTM. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #57, and related tests are added.