Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Incorrect list of supported modules / inverters in docs #145

Closed
ha-enthus1ast opened this issue Jan 8, 2024 · 11 comments
Closed

Bug: Incorrect list of supported modules / inverters in docs #145

ha-enthus1ast opened this issue Jan 8, 2024 · 11 comments
Labels
enhancement New feature or request

Comments

@ha-enthus1ast
Copy link

Hi,

According to the the documentation the list of modules / inverters supported are found here and here.

However, as far as I can tell inverter/modules are retrieved from the oline SAM database. See snippet below

cec_inverters = pvlib.pvsystem.retrieve_sam('cecinverter')

Which indicates, according to pvlib docs that the online database is used.

The actual list of supported modules are located here

Thanks in advance

@davidusb-geek
Copy link
Owner

davidusb-geek commented Jan 8, 2024

Hi,

That's just not the case.
Take a look at this line of code from PVLib, this is the line where the exact same CSV file that I indicate in the documentation is loaded: https://github.com/pvlib/pvlib-python/blob/16017609ea2765c4651dbc13b4743578363b641a/pvlib/pvsystem.py#L2052C71-L2052C71

That's what it is for PVLib. I hope that there will be another method with a more updated database. But there isn't and is up to PVLib developers to update this. Maybe you can open an issue there to ask for this update.
If you're having problems finding you module or inverter model just skip PVLib altogether and use solcast or solar.forecast methods, they work just fine.

@ha-enthus1ast
Copy link
Author

ha-enthus1ast commented Jan 8, 2024

Oh, you are correct. That was very suprising and I think the pvlib documentation is insufficient in this case.

However, looking at the pvlib source you linked, it should be possible to supply your own csv file, right? ie by only passing a path to a cvc file, rather that passing a name.

cec_inverters = pvlib.pvsystem.retrieve_sam('<path_to_custom_csv>')

I am not stuck in any way I was just confused on which file was actually used.

Thanks for getting back to me!

@davidusb-geek
Copy link
Owner

Yes if we can put together un updated version of the CSV file then maybe we can pass it directly yes. it can be an option. Now where can we find this updated version. We need to keep the same formatting as the current CSV file.

@ha-enthus1ast
Copy link
Author

ha-enthus1ast commented Jan 8, 2024

As I mentioned in the issue, pvlib refers to files here where it seems the latest update of the list is for fall 2023. It seems to me that the format of the inverter file has somewhat changed, but the one for the modules seems to be at least similar. Whether any of these potential format changes are supported by pvlib or not i do not know..

@ha-enthus1ast
Copy link
Author

This approach would however require someone to manually update the csv file on new lists. It could of course be retreived from the source by supplying a URL instead, but that is probably a bad idea since it would rely on an internet connection and on the fact that pvlib supports all future formats of the file.

@davidusb-geek
Copy link
Owner

I didn't saw that option to pass a CSV path and from what I can see that updated CSV has the same format except for the last column. I think that we could use that. I will try it and if it works I will include it in the next release.

@ha-enthus1ast
Copy link
Author

Cool thanks!

@ha-enthus1ast
Copy link
Author

Closing issue as invalid, see this comment

@davidusb-geek
Copy link
Owner

davidusb-geek commented Feb 4, 2024

I reopened this issue because we could possible update the CSV files stored in EMHASS to those more updated files from SAM. But this need to be tested.

@davidusb-geek davidusb-geek added the enhancement New feature or request label Mar 11, 2024
@davidusb-geek
Copy link
Owner

I made the needed changes for this. It will be available in the following releases.
Here is a post in the community forum: https://community.home-assistant.io/t/emhass-an-energy-management-for-home-assistant/338126/2031?u=davidusb
And the link to the new webapp to help search the modules and inverter names for your configuration: https://emhass-pvlib-database.streamlit.app/

@davidusb-geek
Copy link
Owner

Released on latest version.
Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: To do
Development

No branches or pull requests

2 participants