Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker Standalone Publish Workspace Fix #207

Merged
merged 20 commits into from
Feb 27, 2024

Conversation

GeoDerp
Copy link
Contributor

@GeoDerp GeoDerp commented Feb 26, 2024

@GeoDerp
Copy link
Contributor Author

GeoDerp commented Feb 26, 2024

Work in progress, still testing.

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.63%. Comparing base (9d85851) to head (20cc256).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #207   +/-   ##
=======================================
  Coverage   87.63%   87.63%           
=======================================
  Files           6        6           
  Lines        1707     1707           
=======================================
  Hits         1496     1496           
  Misses        211      211           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GeoDerp
Copy link
Contributor Author

GeoDerp commented Feb 26, 2024

@davidusb-geek , Im trying to test the DockerHub integration, however having some issues. I may need you to test this one your end.

@davidusb-geek
Copy link
Owner

Ok. I just manually launched the docker publish workflow and it is still failing with some authentication issue.

@GeoDerp
Copy link
Contributor Author

GeoDerp commented Feb 26, 2024

Thanks. I think I might know why. Working it out now 👍

@GeoDerp
Copy link
Contributor Author

GeoDerp commented Feb 26, 2024

Considering how long arm v7 takes to build, I may finish testing this tomorrow. (I think I Just have to check the tags work appropriately now).

So public_docker.yaml has been modified using: https://docs.docker.com/build/ci/github-actions/multi-platform/ as an example.

This workflow is beneficial, as it distributes all the architectures to different runners (making it faster and similar to Emhass-Add-on's matrix).

docker-build-test.yaml file has also been created as an subset of this that works to test the build of each architecture (just like the Add-on version on EMHASS-Add-on )

@GeoDerp
Copy link
Contributor Author

GeoDerp commented Feb 27, 2024

@davidusb-geek , this has been tested. Should be good to go.

@davidusb-geek davidusb-geek merged commit 962a1b7 into davidusb-geek:master Feb 27, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants