Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanced and Basic Pages #212

Merged
merged 15 commits into from
Mar 2, 2024
Merged

Conversation

GeoDerp
Copy link
Contributor

@GeoDerp GeoDerp commented Mar 1, 2024

  • Tool icon has been added to switch between basic and advanced mode.
  • Advance, basic, script have been made into there own files and referenced in index.html .

Basic

Screenshot from 2024-03-01 21-38-08

Advanced

Screenshot from 2024-03-01 21-38-15

@GeoDerp
Copy link
Contributor Author

GeoDerp commented Mar 1, 2024

Based on @purcell-lab 's Idea
PR builds on from PR #211. Hence the duplicate commits.

Please let me know what you would like changed with this. As I don't know this side of EMHASS as mutch as you both.
@purcell-lab , @davidusb-geek

Copy link

codecov bot commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.63%. Comparing base (9d85851) to head (3811b02).
Report is 26 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #212   +/-   ##
=======================================
  Coverage   87.63%   87.63%           
=======================================
  Files           6        6           
  Lines        1707     1707           
=======================================
  Hits         1496     1496           
  Misses        211      211           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GeoDerp
Copy link
Contributor Author

GeoDerp commented Mar 2, 2024

@davidusb-geek , Feel free to just pull in this PR and I will close RP #211.

@davidusb-geek
Copy link
Owner

davidusb-geek commented Mar 2, 2024

@davidusb-geek , Feel free to just pull in this PR and I will close RP #211.

Ok let's go with this PR then.
However could we just let that button on the basic page to just run the optimization without publishing anything. People will just run the optimization and then inspect the graphs. This is useful for testing and setting the add-on parameters without publishing undesired results to HA sensors.

@GeoDerp
Copy link
Contributor Author

GeoDerp commented Mar 2, 2024

@davidusb-geek , Feel free to just pull in this PR and I will close RP #211.

Ok let's go with this PR then. However could we just let that button on the basic page to just run the optimization without publishing anything. People will just run the optimization and then inspect the graphs. This is useful for testing and setting the add-on parameters without publishing undesired results to HA sensors.

Sounds good. Give me a couple of minutes,

@GeoDerp
Copy link
Contributor Author

GeoDerp commented Mar 2, 2024

@davidusb-geek , there you go. Sorry also tweaked the spacing quickly.

@davidusb-geek davidusb-geek merged commit 7f559a3 into davidusb-geek:master Mar 2, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants