Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a function to predict a value from a csv file. Part2 #260

Merged
merged 116 commits into from
May 5, 2024

Conversation

gieljnssns
Copy link
Contributor

@GeoDerp
Copy link
Contributor

GeoDerp commented Apr 19, 2024

@gieljnssns congrats on pulling all these merges off. There really has been a lot changed since you initially released this PR. I'm impressed.

@davidusb-geek
Copy link
Owner

Hi @gieljnssns, is this ready to merge? Other than the needed conflict solve?

optim_conf["def_end_timestep"] = runtimeparams["def_end_timestep"]
if "treat_def_as_semi_cont" in runtimeparams.keys():
optim_conf["treat_def_as_semi_cont"] = [
eval(str(k).capitalize())

Check failure

Code scanning / CodeQL

Code injection Critical

This code execution depends on a
user-provided value
.
]
if "set_def_constant" in runtimeparams.keys():
optim_conf["set_def_constant"] = [
eval(str(k).capitalize()) for k in runtimeparams["set_def_constant"]

Check failure

Code scanning / CodeQL

Code injection Critical

This code execution depends on a
user-provided value
.
perform_backtest = eval(str(runtimeparams['perform_backtest']).capitalize())
params['passed_data']['perform_backtest'] = perform_backtest
if 'model_predict_publish' not in runtimeparams.keys():
perform_backtest = eval(str(runtimeparams["perform_backtest"]).capitalize())

Check failure

Code scanning / CodeQL

Code injection Critical

This code execution depends on a
user-provided value
.
This code execution depends on a
user-provided value
.
params['passed_data']['model_predict_publish'] = model_predict_publish
if 'model_predict_entity_id' not in runtimeparams.keys():
model_predict_publish = eval(
str(runtimeparams["model_predict_publish"]).capitalize()

Check failure

Code scanning / CodeQL

Code injection Critical

This code execution depends on a
user-provided value
.
This code execution depends on a
user-provided value
.
@gieljnssns
Copy link
Contributor Author

Yes, I think so

@davidusb-geek davidusb-geek merged commit 59370c5 into davidusb-geek:master May 5, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants