Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type annotations and static type checking #11

Closed
jawrainey opened this issue May 3, 2020 · 0 comments · Fixed by #29
Closed

Add type annotations and static type checking #11

jawrainey opened this issue May 3, 2020 · 0 comments · Fixed by #29
Assignees
Labels
enhancement New feature or request

Comments

@jawrainey
Copy link
Collaborator

jawrainey commented May 3, 2020

Now we've moved to python 3.8 we should be using code annotations via the typing module. There are many static type checkers available, each of which have their own features (e.g. mypy, pyre, pytype, etc). I suggest that we use mypy in our codebase as it's not large and doesn't need the features the other static checkers have e.g. inference of types in code that do not have type annotations. This PyCon2020 video provides an overview of static typing in python.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant