Fix: buffer messages from external resource #582
Conversation
|
I just ran into it as well. I was about open a PR :-). Thanks @nicomoya123. Any chance this can get merged soon? It has been open for a long time. |
| ? this.deserializer(message, { pattern, channel }) | ||
| : JSON.parse(message, this.reviver); | ||
| if(this.deserializer){ | ||
| parsedMessage = this.deserializer(Buffer.from(message), { pattern, channel }) |
There was a problem hiding this comment.
The serializer/deserializer may not be dealing with buffers at all. I think the original code is correct. I think the only change needed is the check above for whether channel is an object.
There was a problem hiding this comment.
I might not remember correctly, but I think this is when you set it using the config. Do you have a test case where this is incorrect?
There was a problem hiding this comment.
Yes, there are some serialization/deserialization libraries that don't necessarily output buffers or take in buffers. They could be encoding/decoding using strings (inefficient, I know). But then, I guess they would not be setting the eventName to messageBuffer in the config. So this is likely ok.
|
@davidyaha can this be merged ? |
|
Thanks @nicomoya123 and sorry for the delay |
תודה !