This repository has been archived by the owner on Jun 24, 2024. It is now read-only.
Fix crash #12
Merged
Fix crash #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are a lot of commits but they are only to synchronize the changes, only the last 2 are the fixes |
|
Hmm... I've never experienced a crash from the normalize_volume option. Is this from a custom-implemented track? Because iirc (and even in index.d.ts), the volume property is non-nullable. Other than that, LGTM |
|
Would you mind rebasing for me and using cherry-pick rather than merging? |
|
I saw it too late, sorry |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both errors checked
Thanks to Rubén Ortiz