Max width on anchor preview #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoid the preview to be larger than the screen on very large link
daviferreira
added a commit
that referenced
this pull request
Apr 30, 2015
Max width on anchor preview
nysk
pushed a commit
to nysk/medium-editor
that referenced
this pull request
Aug 10, 2015
Max width on anchor preview
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Few littles fixes:
Link too large
This avoid the preview to be larger than the screen on very large link (like Medium does).
Here is before that PR with a large link:
And after, with the same link:
Bad position
I got some problem when the anchor is positionned. The fixed value of
buttonHeightwas the problem. Using offset of the current position of the anchor fixed the issue.Preview before:
preview after:
