Skip to content

Commit

Permalink
Rename code smell to 'Avoid exposing your internals'
Browse files Browse the repository at this point in the history
  • Loading branch information
davidtan-tw committed Jul 19, 2019
1 parent 3dcba26 commit 3590227
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
- Use default arguments instead of short circuiting or conditionals - Use default arguments instead of short circuiting or conditionals
- Don't use flags as function parameters - Don't use flags as function parameters
- [Design](docs/design.md) - [Design](docs/design.md)
- Set boundaries (Keep implementation details hidden) - Avoid exposing your internals (Keep implementation details hidden)


## Introduction ## Introduction


Expand Down
2 changes: 1 addition & 1 deletion docs/cheat-sheet.md
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ This is by far the most important rule in software engineering. When functions d


## Design ## Design


### Don't expose your internals (Keep implementation details hidden) ### Avoid exposing your internals (Keep implementation details hidden)


Functions and classes simplify our code by abstracting away complicated implementation details and replacing them with a simpler representation - its name. When implementation details are all laid bare in a Jupyter notebook without any abstractions (functions), we are forced to understand the **how**'s in order to find out **what**'s happening. Functions and classes simplify our code by abstracting away complicated implementation details and replacing them with a simpler representation - its name. When implementation details are all laid bare in a Jupyter notebook without any abstractions (functions), we are forced to understand the **how**'s in order to find out **what**'s happening.


Expand Down
2 changes: 1 addition & 1 deletion docs/design.md
Original file line number Original file line Diff line number Diff line change
@@ -1,6 +1,6 @@
## **Design** ## **Design**


### Set boundaries (Keep implementation details hidden) ### Avoid exposing your internals (Keep implementation details hidden)


Functions and classes simplify our code by abstracting away complicated implementation details and replacing them with a simpler representation - its name. When implementation details are all laid bare in a Jupyter notebook without any abstractions (functions), we are forced to understand the **how**'s in order to find out **what**'s happening. Functions and classes simplify our code by abstracting away complicated implementation details and replacing them with a simpler representation - its name. When implementation details are all laid bare in a Jupyter notebook without any abstractions (functions), we are forced to understand the **how**'s in order to find out **what**'s happening.


Expand Down

0 comments on commit 3590227

Please sign in to comment.