Optimize rebar compiler settings #236
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
big-r81
commented
Jun 5, 2024
big-r81
commented
- remove some old settings which are in the default port compiler environment templates
- add rebar2 artifact setting for compiling on Windows
|
Thanks for the PR @big-r81 I incorporated the .dll artifacts setting patch in the CI PR I made already. But noticed that it was passing on windows 2019 and 2022 without the patch, should we retest with jiffy 1.1.2, perhaps2? |
|
@nickva Does it work with rebar2 too? Could you integrate this into the CI run? |
|
Not a bad idea but it will be a bit harder as we'd have to install rebar2 by hand. On Ubuntu Erlang/OTP images they already have rebar2 installed but on windows we'd have to do ourselves. |
|
Yeah, maybe similar we do the rebar2 install within CouchDB… |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.