Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ahnen_parents function to take an array and produce an Ahnentafel number #4

Merged
merged 2 commits into from
May 9, 2023
Merged

Conversation

yewtc
Copy link
Contributor

@yewtc yewtc commented May 9, 2023

Given an array of strings like ("Father, "Grand Mother","Great Grand Mother", ...), the ahnen_parents function

Creates the Ahnentafel appropriate number . In pratice it matches on/Mother/iin the string, so all else if noise.

@coveralls
Copy link

coveralls commented May 9, 2023

Coverage Status

Coverage: 100.0%. Remained the same when pulling aabf4d1 on yewtc:ahnen_parents into 235b7a8 on davorg:master.

@davorg
Copy link
Collaborator

davorg commented May 9, 2023

Hi Steve,

This looks useful, but could you change it to use the parent_names class attribute? That way it would continue to work if someone subclasses the module to support a different language.

@davorg davorg merged commit d0c532a into davorg-cpan:master May 9, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants