-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removed ampersands on subroutine calls #7
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this, but please ensure that the tests pass before submitting a PR.
|
||
eval "&c"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a typo.
@@ -10,7 +10,7 @@ sub qux {12} | |||
package y; | |||
use Symbol::Approx::Sub (canon => undef, | |||
match => sub {shift; return 0 .. $#_}); | |||
Test::More::ok(&x::quux()==12); | |||
Test::More::ok(&y::quux()==23); | |||
Test::More::ok(x()::quux()==12); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be x::quux()
.
@@ -1,7 +1,7 @@ | |||
use Test::More tests => 1; | |||
|
|||
use Symbol::Approx::Sub(xform => undef, | |||
match => \&always_bb); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was correct as we're taking a reference to the subroutine, not calling it.
I think you've missed a couple, but I'll merge this PR and do the rest myself. Thanks. |
I removed the ampersands on subroutine calls and pushed the whole folder