Fix ./Build disttest ( issue#50 ). #51
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add missing files to the manifest by running " ./Build manifest ".
6 similar comments
|
Seems like travis-ci should also test "./Build disttest" but it doesn;t now. |
atoomic
reviewed
Feb 6, 2019
| @@ -1,5 +1,5 @@ | |||
| .travis.yml | |||
There was a problem hiding this comment.
this file should be skipped from the Manifest, please add it to MANIFEST.SKIP
|
Please view comment and remove |
|
Thanks. But I made this fix literally moments before seeing this PR. |
|
@davorg : thanks! |
shlomif
added a commit
to shlomif/xml-feed
that referenced
this pull request
Feb 7, 2019
To avoid future problems such as davorg-cpan#51 and davorg-cpan#50 .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing files to the manifest by running " ./Build manifest ".