Skip to content

Commit

Permalink
cmds: Remove redundant query message
Browse files Browse the repository at this point in the history
The first line of the body in the "Rename Remote" dialog is redundant and
unnecessary, this patch removes the message and changes the interaction
to a question.

The new interaction choice might not be sane though, please review.

Fixes git-cola#838.

Refer-to: Redundant query message · Issue git-cola#838 · git-cola/git-cola <git-cola#838>
Signed-off-by: 林博仁 <Buo.Ren.Lin@gmail.com>
  • Loading branch information
Vdragon committed Jun 11, 2018
1 parent e9cbfb3 commit 58e2cb0
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions cola/cmds.py
Expand Up @@ -686,11 +686,9 @@ def __init__(self, name, new_name):

def confirm(self):
title = N_('Rename Remote')
question = N_('Rename remote?')
info = (N_('Rename remote "%(current)s" to "%(new)s"?') %
dict(current=self.name, new=self.new_name))
ok_text = N_('Rename')
return Interaction.confirm(title, question, info, ok_text)
return Interaction.question(title, info)

def action(self):
git = self.model.git
Expand Down

0 comments on commit 58e2cb0

Please sign in to comment.