Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure custom_slide_count always uses same total #5

Merged
merged 1 commit into from
May 12, 2012

Conversation

rschroll
Copy link

With a custom ending slide, the presenter and overview could give different numbers for the total slides. This fixes that by figuring the total number of slides directly in custom_slide_count.

@davvil
Copy link
Owner

davvil commented May 12, 2012

That was actually intentional. As you are seeing all the slides at one time, I though having the global total was (slightly) better. I was doubting between both possibilities without a clear favorite, though, so I could be easily convinced otherwise.

@rschroll
Copy link
Author

A few (weak) arguments in favor of the change:

  • The user is not expecting anything about the page count to change by changing the view.
  • The user may fear that the custom end page has been lost by switching to the overview.
  • In the overview mode, the user already can see where the selection is relative to the total number of slides, so duplicating that info isn't as useful. What's harder to see at a glance is where they are relative to the marked end, so adding that info as text is more useful.

Of course, the current behavior isn't that bad, so I won't be upset if you don't make the change.

davvil added a commit that referenced this pull request May 12, 2012
Ensure custom_slide_count always uses same total
@davvil davvil merged commit 4e09a88 into davvil:master May 12, 2012
@davvil
Copy link
Owner

davvil commented May 12, 2012

Ok, you convinced me ;-)

@tinloaf tinloaf mentioned this pull request Jan 2, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants