Update to latest RK version #3

davwillev · 2019-02-21T12:17:00Z

No description provided.

Merge ORK-latest

… on build

// implicit self retain in blocks, priority inversion are larger issues to tackle

…1214)

…l of ORKAnswerFormat

…ties, adding checks before assigning

… detail text in ORKAnswerFormat

… non-nil

- Tidy up localized strings - Remove unused language config - Delegate reference cycle - Tidy signature access at end of onboarding Minor syntax tidy Minor Tidy, remove redundant check Minor tidy, remove unnecessary variable Minor tidy, clearer call Fix broken “Disagree” button in example onboarding consent flow Previously the flow let you progress as usual even if you select “disagree” Remove development team Clean whitespace

…Element

[Project Hardening] Improvements (III)

bgannin and others added 30 commits November 21, 2018 15:38

Merge pull request #1 from ResearchKit/master

6459a4a

Merge ORK-latest

Enable a swath of new compiler and analyzer flags and shallow analyze…

336ab0e

… on build

[code cleanup] Resolve missing super calls (issue #1214)

3736cf5

[code cleanup] Resolve generics type mismatch (issue #1214)

f3929e0

[code cleanup] Fix memory management/mutability mismatch (issue #1214)

336096f

[code cleanup] Add missing newlines (issue #1214)

fbb7892

[code cleanup] Remove extraneous semicolons (issue #1214)

a033e1c

[code cleanup] Fix unknown pragmas (issue #1214)

5c3fe6e

[code cleanup] Security fixes for random, loop counter (issue #1214)

1a902ee

[code cleanup] Fix dead code stores (issue #1214)

db995e3

[code cleanup] Resolve shadow declarations (issue #1214)

ca81287

[code cleanup] Address missing prototypes for functions (issue #1214)

fc61990

[code cleanup] Add missing localization comments (issue #1214)

c2b664f

[code cleanup] Use defined enum values (issue #1214)

6007603

[code cleanup] Review mismatched nil returns (issue #1214)

9ef1876

Tweak build settings a bit (issue #1214)

30a758e

// implicit self retain in blocks, priority inversion are larger issues to tackle

[code cleanup] Resolve semantic issue with navigation buttons (issue #…

421e906

…1214)

[code cleanup] Use local variable across autorelease pools (issue #1214)

547e1b5

[code cleanup] Review mismatched nil returns, part II (issue #1214)

35e5d5a

adding support for setting attributed string to the primary text labe…

610d30f

…l of ORKAnswerFormat

setting attributed text to nil seems to override other UILabel proper…

cd216ab

…ties, adding checks before assigning

adding support to provide attributed string for both primary text and…

612b411

… detail text in ORKAnswerFormat

display attributed strings in picker view

3cd8cd7

ensure that attributedText always overrides text

ab081e2

support attributedText in textScaleAnswerFormat

630a431

support attributedText in ORKMultipleValuePickerAnswerFormat

7f37428

call designated initializer using self

599a723

account for case where text is nil but primaryTextAttributedString is…

111b983

… non-nil

renaming an internal function

36b8a72

rsanchezsaez-apple and others added 29 commits February 20, 2019 17:56

Rename ORKLineGraphAccessibilityElement to ORKGraphChartAccessibility…

b412f47

…Element

[ORKGraphChartView] Simpler fix for shadowing variable declaration

1c2af3c

[ORKGraphChartView] Simpler fix for shadowing variable declaration

16a5da4

[ORKHealthAnswerFormat] Better nullability issue fix

81b945a

[ORKDateTimePicker] Better nullability test

363a1f7

Remove unneeded check

ea01dbd

Update comment to reflect code

762d035

[ORKHealthAnswerFormat] Better static analyzer fixes

6f883b4

[Misc] Rename findInArrayByKey to ORKFindInArrayByKey

15b6204

[ORKMultiValuePicker] Better nullability fix

97a503c

[Misc] Nicer variable names

222855f

[ORKPicker] Better nullability fix, remove unused function

2e0bef5

[ORKReviewStep] Add extra nullable annotations

4d7c27a

[ORKReviewStep] Add braces for safety

ddb2c50

[ORKSkin] Remove unused code

92c2299

[ORKStepNavigationRule] Improve comment

d6f71e2

[ORKTableStepViewController] Better nullability

319b9f1

[ORKTaskViewController] Better UUID nullability

08af95d

[ORKPDFViewerStepView] Add default nullability

82720f2

[ORKTintedImageView] Remove unneeded nullability

61290e4

[ORKTintedImageView] Remove unneeded changes

e4f7516

[ORKVisualContentStepViewController] Better nullability handling

5bc0088

[ORKValuePicker] Undo unneeded changes

54feccd

[ORKConsentSection] Remove unneeded import

6e61d4f

[ORKSpeechRecognitionResult] Fix typo

63fb484

[Misc] Add a space before every ‘nil’

f614fda

[ORKTaskViewController] Remove unneeded implementation

61af3f9

[ORKTaskViewController] More compact nil UUID check

19de603

Merge pull request #1245 from ResearchKit/rss/project-hardening-c

d000f5b

[Project Hardening] Improvements (III)

davwillev merged commit 7235e9e into davwillev:master Feb 21, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update to latest RK version #3

Update to latest RK version #3

davwillev commented Feb 21, 2019

Update to latest RK version #3

Update to latest RK version #3

Conversation

davwillev commented Feb 21, 2019