Skip to content

Commit

Permalink
Crash when closing Polyphone
Browse files Browse the repository at this point in the history
Audio connections were not closed
  • Loading branch information
davy7125 committed Dec 24, 2021
1 parent 7a66a62 commit 80adb97
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions sources/context/audiodevice.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ AudioDevice::AudioDevice(ConfManager *configuration) : QObject(nullptr),

AudioDevice::~AudioDevice()
{
closeConnections();
if (_initialized)
Pa_Terminate();
delete _synth;
Expand Down
4 changes: 2 additions & 2 deletions sources/editor/tools/sound_spatialization/graphspace.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ void GraphSpace::paintEvent(QPaintEvent *event)
painter.drawLine(0.5 * this->width(), -1, 0.5 * this->width(), this->height() + 1);

// Data
painter.setPen(QPen(this->palette().color(QPalette::Highlight), 2.0, Qt::SolidLine));
painter.setPen(QPen(this->palette().color(QPalette::Highlight), 3.0, Qt::SolidLine));

This comment has been minimized.

Copy link
@mirabilos

mirabilos Dec 27, 2021

Contributor

Was this change deliberate here? It does not match the commit message.

This comment has been minimized.

Copy link
@davy7125

davy7125 Dec 27, 2021

Author Owner

No it was a change I silently commited here, hoping someone would notice...

for (int i = 0; i < _xPan.size(); i++)
painter.drawLine(
_xPan[i] * (this->width() - 2 * margin) + margin,
Expand All @@ -134,7 +134,7 @@ void GraphSpace::paintEvent(QPaintEvent *event)
if (!_currentLabel.isEmpty())
{
colorTmp.setAlpha(255);
painter.setPen(QPen(colorTmp, 3.0));
painter.setPen(QPen(colorTmp, 1.0));

This comment has been minimized.

Copy link
@mirabilos

mirabilos Dec 27, 2021

Contributor

Was this change deliberate here? It does not match the commit message.

This comment has been minimized.

Copy link
@davy7125

davy7125 Dec 27, 2021

Author Owner

(same)


font.setPointSize(9);
font.setBold(true);
Expand Down

1 comment on commit 80adb97

@davy7125
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix #112

Please sign in to comment.